search

eggjs / tegg

Strong Type framework with eggjs.
MIT License
240 stars 35 forks source link

feat: impl MultiInstance inject MultiInstance #240

Closed killagu closed 1 month ago

killagu commented 1 month ago
Checklist
Affected core subsystem(s)
Description of change

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago

Walkthrough

The changes include significant updates across multiple files, primarily focusing on the introduction of multi-instance prototype handling within the application. Key modifications involve the addition of new classes, methods, and properties to manage multi-instance dependencies, as well as updates to existing methods to accommodate these new functionalities. Configuration files for various modules have also been created or updated to support the new structure, enhancing the application's modular capabilities.

Changes

File Path Change Summary
core/metadata/src/impl/LoadUnitMultiInstanceProtoHook.ts Converted multiInstanceClazzSet to a static property, modified preCreate method, added setAllClassList and clear static methods.
core/metadata/src/impl/ModuleLoadUnit.ts Introduced MultiInstanceProtoNode class, updated ModuleGraph to handle both ProtoNode and MultiInstanceProtoNode, refactored loadClazz to doLoadClazz.
core/metadata/src/model/AppGraph.ts Added properQualifiers to InstanceClazzMeta, modified dependency handling in AppGraph, added getClazzList method.
core/metadata/test/AppGraph.test.ts Added a test case for multi-instance injection functionality.
core/metadata/test/LoadUnit.test.ts Introduced lifecycle management for LoadUnitMultiInstanceProtoHook, added a test case for multi-instance injection.
core/metadata/test/fixtures/modules/app-multi-inject-multi/... Created multiple new files for modules (App, App2, BizManager, Secret), added configuration files (module.yml, package.json).
core/types/core-decorator/model/EggMultiInstancePrototypeInfo.ts Added properQualifiers property to ObjectInfo interface.
core/types/core-decorator/model/EggPrototypeInfo.ts Added properQualifiers property to EggPrototypeInfo interface.
plugin/dal/lib/DataSource.ts Injected TransactionalAOP into DataSourceDelegate class.
plugin/tegg/app.ts Added call to LoadUnitMultiInstanceProtoHook.clear() in lifecycle management.
plugin/tegg/lib/EggModuleLoader.ts Imported LoadUnitMultiInstanceProtoHook and set class list from appGraph.
plugin/tegg/test/MultiInstanceInjectMultiInstance.test.ts Established tests for dynamic injection of multiple instances.
plugin/tegg/test/fixtures/apps/app-multi-inject-multi/... Created multiple new files for modules and configurations related to multi-instance injection.
plugin/tegg/test/fixtures/apps/app-multi-inject-multi/config/... Introduced configuration files for application settings and plugin management.
standalone/standalone/src/EggModuleLoader.ts Added import for LoadUnitMultiInstanceProtoHook and set class list from appGraph.

Poem

🐇 In the meadow, changes bloom,
Multi-instances make room,
Classes dance and methods play,
New configurations lead the way.
With each hop, the code takes flight,
A rabbit's cheer for code's delight! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
killagu commented 1 month ago