search

eggplantbren / DNest3

Diffusive Nested Sampling
GNU General Public License v3.0
20 stars 6 forks source link

Revamping the directory structure and Makefiles #3

Closed dfm closed 12 years ago

dfm commented 12 years ago

This pull request removes a lot of the duplicated code from the Makefiles and it improves the build process. I also moved the source code to an src directory because I think that it's a much cleaner structure and it will improve the lives of people that want to write Python bindings to this library :-)

I understand that this pull request might be too opinionated to just merge right in but I think that the changes to the build process are at least worth incorporating.

eggplantbren commented 12 years ago

Thanks for this Dan. I'll take a detailed look some time soon and consider merging in your changes. I think a more conventional directory layout would have the .h files in /include and the .cpp files in /src. Would that work for someone who wanted to write Python bindings?

dfm commented 12 years ago

Yep I thought about that too... that would be fine!

eggplantbren commented 12 years ago

Ok. I'll think about that later - for now, everying in src/ should be fine. I just pulled your changes to an experimental branch on my own computer, and it has an issue or two. I'm not an expert on Makefiles, so I thought I'd ask you. Everything builds fine, but 'make clean' doesn't delete .o files in the root directory. It tries to delete .o files in src/. If you compile a file with g++ like this: g++ -c SomeDir/SomeFile.cpp Then SomeFile.o will be created in the current directory, not SomeDir.

eggplantbren commented 12 years ago

Please disregard my last comment entirely. The leftover .o files were from me compiling the older version.

I created a tag to archive the current version which I consider stable. I am now happy with your changes and will merge them. Thanks!