eggplantbren / DNest4

Diffusive Nested Sampling
MIT License
62 stars 22 forks source link

New distributions #21

Closed j-faria closed 6 years ago

j-faria commented 6 years ago

I added a couple of new distributions and their truncated versions. Feel free to rename Jeffreys -> Reciprocal, or something like that if you want: that name stuck in the exoplanet field but it's not the best. I also changed the makefile to not recompile every time and to not compile the examples by default.

eggplantbren commented 6 years ago

Would you mind if I change some things before accepting this?

j-faria commented 6 years ago

Of course not :)

eggplantbren commented 6 years ago

One of those things will be to rename Jeffreys to LogUniform ;-), but you can just put a using declaration in kima to make it an alias.

using Jeffreys = LogUniform;

or

typedef LogUniform Jeffreys;

ought to work.

eggplantbren commented 6 years ago

Okay, I did rename it but I put the alias in there as well so you needn't change anything in kima.

j-faria commented 6 years ago

Awesome! But if you change your mind, I also think LogUniform makes total sense. With this it should be much easier to keep things up to date in kima. Thank you!