eggplants / get-pixivpy-token

Get your Pixiv token easily (for running upbit/pixivpy)
MIT License
117 stars 9 forks source link

Wrong gppt version in docker image #52

Closed narugo1992 closed 1 year ago

narugo1992 commented 1 year ago

When I run the following command to enter the container (version 3.1.0)

docker run --entrypoint /bin/bash --rm -it ghcr.io/eggplants/get-pixivpy-token:3.1.0

Then run pip list, this is the result

root@c4ee03b30364:/# pip list                                                                        
Package              Version
-------------------- ---------                  
async-generator      1.10             
attrs                22.2.0                       
certifi              2022.12.7
cffi                 1.15.1                                                                          
charset-normalizer   2.1.1                                                                                                                                                                                 
cloudscraper         1.2.68                                                                          
cryptography         39.0.0                   
gppt                 3.0.0                                                                                                                                                                                 
h11                  0.14.0
idna                 3.4 
outcome              1.2.0                                                                                                                                                                                 
pip                  23.0                                                                            
PixivPy3             3.7.2                                                                                                                                                                                 
pwinput              1.0.2
pycparser            2.21
pyderman             3.3.0                                                                                                                                                                                 
pyOpenSSL            23.0.0                                                                          
pyparsing            3.0.9                                                                                                                                                                                 
PySocks              1.7.1 
requests             2.28.1
requests-toolbelt    0.10.1                 
selenium             4.3.0                   
setuptools           65.5.1                                                                          
sniffio              1.3.0                    
sortedcontainers     2.4.0                     
trio                 0.22.0                   
trio-websocket       0.9.2                    
types-requests       2.28.1                    
types-urllib3        1.26.25.4                
typing_extensions    4.4.0                      
urllib3              1.26.14                    
urllib3-secure-extra 0.1.0                    
wheel                0.38.4                   
wsproto              1.2.0

Gppt version is actually 3.0.0, instead of 3.1.0.

This should be because the pypi package and the docker image are paralleled on the github action workflow, so pypi may not have been deployed properly when docker is still building. My suggestion is to use the previously packaged whl file to install directly during docker build to ensure that the gppt version is correct.

eggplants commented 1 year ago

Just republished. Thank you for your report.

$ docker run --entrypoint bash --rm -i ghcr.io/eggplants/get-pixivpy-token:3.1.0 <<<'pip list | grep gppt'
gppt               3.1.0
narugo1992 commented 1 year ago

Emmm, I think you may need to change the workflow of github action, just put the ghcr job strictly after pypi job, passing the whl file from pypi job and install it. Otherwise the docker image of next version will still have the same problem.

eggplants commented 1 year ago

462e4d20e67297cb70968ebe8be58d461dfc20bc

eggplants commented 1 year ago

ref: https://github.com/eggplants/shtris-docker