search

eggswift / ESTabBarController

:octocat: ESTabBarController is a Swift model for customize UI, badge and adding animation to tabbar items. Support lottie!
MIT License
5.18k stars 580 forks source link

Fix issue that resulted in incorrect tabBar layout if device was held in landscape but set to portrait mode #114

Closed rami-ihr closed 6 years ago

rami-ihr commented 6 years ago

This is what can happen if you hold the device in landscape when the app only support portrait mode. Note the text being to the right of the icons instead of below it. So in that case it is better to check that the main window is actually in landscape instead of using device orientation.

simulator screen shot - iphone x - 2017-11-29 at 10 33 00

eggswift commented 6 years ago

Look good！ Thanks