eggswift / ESTabBarController

:octocat: ESTabBarController is a Swift model for customize UI, badge and adding animation to tabbar items. Support lottie!
MIT License
5.18k stars 580 forks source link

Icons became very small after upgrading from 2.5 to 2.6.1 #132

Closed ranhsd closed 6 years ago

ranhsd commented 6 years ago

Hi, I am using this library in my project and after updating from version 2.5 to 2.6.1 I've noticed that the tab icons size has changed and now they are very small. My tab bar design is image only. Each icon size is 40x40. I wanted to know if this change is by design or it's a bug?

Thanks!

goktugaral commented 6 years ago

Same here!

harelw commented 6 years ago

For some reason tab icons are set to 23*23 here: https://github.com/eggswift/ESTabBarController/commit/925eaaba8942e0bd722e145fb5d56854b1f229a3#diff-54c7e751ff0783ea0af07d351672ea29R210

This set size shouldn't be enforced as it doesn't even follow Apple guidelines.

tempurai commented 6 years ago

Same here

ranhsd commented 6 years ago

In version 2.5 everything works well.. I really don't know why they decided to change it...

chenfengfeng commented 6 years ago

override func updateLayout() { super.updateLayout() self.imageView.sizeToFit() self.imageView.center = CGPoint.init(x: self.bounds.size.width / 2.0, y: self.bounds.size.height / 2.0) }

ranhsd commented 6 years ago

Hi @chenfengfeng What I am doing currently is use the 2.5 version in my project and not the latest one

chenfengfeng commented 6 years ago

@ranhsd 2.5版本不需要做任何操作,新版本重构了 image 尺寸,如果希望使用自己 icon 的尺寸,需要重写updateLayout方法 ps:English is not good😂

Bogon commented 6 years ago

Same here!

harelw commented 6 years ago

@eggswift is this project abandoned?

nezhyborets commented 6 years ago

Same question here

nezhyborets commented 6 years ago

Have anyone forked a fix for this one?

eggswift commented 6 years ago

@all Use .itemContentMode to custom this func, and see it works or not. If you want use image size, use .alwaysOriginal

ranhsd commented 6 years ago

Hi @eggswift It's not working ... I still see small icons