search

eggswift / pull-to-refresh

#Busy Re-Building....# An easy way to use pull to refresh and infinite scrolling in Swift. Pod 'ESPullToRefresh'
MIT License
1.82k stars 252 forks source link

Adapter Swift4 #94

Closed xiaobs closed 6 years ago

piv199 commented 6 years ago

@eggswift do you need any help for this task?

xiaobs commented 6 years ago
default

Hello, please resolve “declarations in extensions cannot override yet” in Swift4

Pulichev commented 6 years ago

Should we just make from an extension a subclass?

Pulichev commented 6 years ago

I think, that this pod is unsupported :(

piv199 commented 6 years ago

@Pulichev have you tried any other similar pods with swift4?

Pulichev commented 6 years ago

@piv199 no I'll think some time, how can I fix this. If no ideas - will look for a new

eggswift commented 6 years ago

@piv199 @Pulichev @xiaobs Sorry about my heavy works these days. I'll fix it this week. Thanks for this issue.

xiaobs commented 6 years ago

Waiting for your update. Thank you very much!

Pulichev commented 6 years ago

Wow! Thank you so much for supporting!:)

siberianisaev commented 6 years ago

temp fix added pod 'ESPullToRefresh', :git => 'https://github.com/siberianisaev/pull-to-refresh.git', :commit => '702aa5aa01515818c96a2986f14def6a71445848' (not sure correct or not, but working for me)

Separate issue. In the client code es_ prefix must be replaced with es.. Need to update Readme

Pulichev commented 6 years ago

I have also fixed it.

commented like 

//}

//public extension ESRefreshComponent /* Action */ {

in ESPullToRefresh and ESRefreshComponent

Find this places.

Also added @objcprefix to problematic functions.

Good luck

annjawn commented 6 years ago

@siberianisaev your fixes works perfectly. It should be merged to master and the documentation should be updated with the es. bit.