search

egguy / addon-grott-beta

An HA addon base on the 2.8 branch + gott HA plugin
7 stars 1 forks source link

Optimization: check the inverter mapping for troublemakers #36

Closed typxxi closed 2 months ago

typxxi commented 3 months ago

I guess you have a list of supported inverters at least on the mapping level like min sph max or so

You could check the values if there is an unknown 3 letter element and then reject to save cause: "mic inverters are not supported yet. please read the documentation carefully" And there you can write that only the min, sph and max series are supported. In case you have a mic try to use MIN instead.

same for those with typos like "mix" or "mib" cause such mic error can take a time to find and fix and cause issues here which could be avoided. I have struggled with that 2 times, where the first time I got the solution from you and the second time I could not believe it cause the 8 inverter long mapping line had still contained 2 oe 3 old "mic" !

And therefore a check and message would be usefull to avoid further troubles cause in my case I have a report every minute, the usual user will have a report / update only every 5th minute and therefore will recognise the issue far later.

github-actions[bot] commented 2 months ago

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!