search

eggxp / google-breakpad

Automatically exported from code.google.com/p/google-breakpad
0 stars 0 forks source link

binarystream::rewind() should clear error state flags #460

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
As in other STL stream implementations, rewind() is supposed to clear error 
state flags. However, the binarystream class in src/processor/binarystream.h 
only calls seekg/seekp, which only clear the EOF bit but not error state flags. 
It should call stream_.clear() to clear error state flags.

Original issue reported on code.google.com by benc...@chromium.org on 9 Jan 2012 at 5:28

GoogleCodeExporter commented 9 years ago 
This issue was reported and fixed in downstream google-breakpad in Chromium OS: 
https://gerrit.chromium.org/gerrit/#change,7797

Original comment by benc...@chromium.org on 9 Jan 2012 at 5:29

GoogleCodeExporter commented 9 years ago 
Fixed in r901.

Original comment by benc...@chromium.org on 9 Jan 2012 at 7:44

GoogleCodeExporter commented 9 years ago

Original comment by benc...@chromium.org on 9 Jan 2012 at 7:45