Closed jblachly closed 8 years ago
Thanks! This looks good. I have a few things I'd like to change, but I can do this later:
--cusip
and just make this the default behavior. I really can't see why the CUSIP would be better than the ticket symbol. The only reason it did that before is because I didn't know what I was doing. :)
This addresses issue #10
Caveats: I could not construct a test using existing tests as a template, because these test the output of transaction formatting, etc., whereas this commit modifies the entire output of print_results (indeed, the transformation is done in print_results() because it is the final common pathway of the program).
I did include test fixture data (cusip.ofx) for when a test is constructed; this test data includes a stock/mf transaction, a non-reinvested dividend, and a position.
General comments on structure:
ofx
object in theprint_results()
function. Because txns is a list of references to a subset ofofx.account.statement.transactions
, they are automagically modified as well. If this changes, we need to rewrite the conversion process.