search

egh / ledger-autosync

Synchronize your ledger-cli files with your bank.
GNU General Public License v3.0
273 stars 42 forks source link

Don't access keyring when not needed #54

Open DamienCassou opened 6 years ago

DamienCassou commented 6 years ago

When using ledger-autosync to read an existing ofx file, I don't expect ledger-autosync to access my keyring and ask me to unlock it. This annoys me because I don't use Gnome keyring and I don't want any application to use it and ask me to unlock it.

egh commented 6 years ago

Thanks for the report! I haven't been using gnome keyring with ledger-autosync so I haven't seen this. Did you need to configure it explicitly, or was it configured when you ran ofxclient?

DamienCassou commented 6 years ago

Did you need to configure it explicitly

I haven't configured anything.

or was it configured when you ran ofxclient?

I don't use ofxclient. I get my ofx files through boobank.

egh commented 6 years ago

Great, I'll try to replicate this behavior locally.

(As an aside, I didn't know boobank could fetch OFX files. I'll have to check it out.)

rcurtin commented 5 years ago

@DamienCassou @egh this seems to be a result of ofxclient. I opened an issue there: https://github.com/captin411/ofxclient/issues/78

My workaround is to comment out the import keyring and keyring.get_password() lines from ofxclient/cli.py, and also set KEYRING_AVAILABLE to False always.

Hope this helps!

egh commented 5 years ago

Thank you, Ryan!

jlesieutre commented 8 months ago

For anybody still having this problem (it's still there in ofxclient), this still solves the problem as of 1/2024 except that the offending lines to comment out have moved to ofxclient/config.py