search

egh / ledger-autosync

Synchronize your ledger-cli files with your bank.
GNU General Public License v3.0
273 stars 42 forks source link

Multi account OFX support #63

Open fabrepe opened 5 years ago

fabrepe commented 5 years ago
fabrepe commented 5 years ago

New commit (f49b743) fix some errors when syncing instead of importing from an OFX file. I don't know if I need to cancel this pull request and create another one.

egh commented 5 years ago

Closing & re-opening to trigger travis build.

egh commented 5 years ago

Sorry, I had broken tests and for some reason the travis-ci integration had stopped working. Can you merge in master to this branch to fix the tests? Thank you!

fabrepe commented 5 years ago

Sorry for the delay, master branch has just been synced in the fabrepe/ledger-autosync

501st-alpha1 commented 5 years ago

This branch has been working for me. :+1:

One unfortunate thing about the way my bank builds my OFX files is that if a given account doesn't have any transactions for the selected period, it will not be included in the OFX file. Thus I have some files with e.g. all 5 accounts, some with only 3, some with another set of 3, and so on. (The relative ordering appears to be constant though.)

So another useful feature would be the ability to link account names to account numbers, and just ignore any extra account arguments. I'd be fine with leaving that for another PR though.

501st-alpha1 commented 5 years ago

One unfortunate thing about the way my bank builds my OFX files is that if a given account doesn't have any transactions for the selected period, it will not be included in the OFX file. Thus I have some files with e.g. all 5 accounts, some with only 3, some with another set of 3, and so on. (The relative ordering appears to be constant though.)

So another useful feature would be the ability to link account names to account numbers, and just ignore any extra account arguments. I'd be fine with leaving that for another PR though.

My bank actually just updated their transaction downloading interface, and transactions are now limited to a single account, so this is no longer an issue for me. (Not to say that this might not still be a useful feature, but just that I no longer have immediate need of it.)