search

egh / ledger-autosync

Synchronize your ledger-cli files with your bank.
GNU General Public License v3.0
273 stars 42 forks source link

Remove unused fuzzy account matching #65

Closed burkemw3 closed 5 years ago

burkemw3 commented 5 years ago

Tested with python3 -m nose -a generic on OSX.

Before removing, I did try using fuzzywuzzy on my ledger setup. First, the results it returned were actually an array instead of a single entry like get_account_by_payee. Second, the array results were very bad.

egh commented 5 years ago

Interesting - I guess I've never really used this. It was written by @scottmtp but then I guess I broke it. Sorry, Scott :( I should probably get a better handle on account matching. @scottmtp how do you feel about removing this? Or is this something we can do to improve it?

egh commented 5 years ago

Closing & re-opening to trigger travis build.

egh commented 5 years ago

Sorry, I had broken tests and for some reason the travis-ci integration had stopped working. Can you merge in master to this branch to fix the tests? Thank you!

burkemw3 commented 5 years ago

rebased & travis tests passing :)

burkemw3 commented 5 years ago

Also, I'm okay waiting for @scottmtp to weigh in, before this gets merged. It was simply a cleanup opportunity I recognized.

scottmtp commented 5 years ago

No worries, I'm fine if the fuzzy account matching is removed.