eginez / calvin

A minimalistic build tool for clojurescript projects that does not require the jvm
186 stars 9 forks source link

Project clj warnings #10

Closed plexus closed 7 years ago

plexus commented 7 years ago

@eginez this is already a significantly bigger patch. I hope that's cool... If you have any feedback on this I'm happy to incorporate it. I'm also able to split this up if there are parts of it you do or don't like.

As far as functionality this

Apart from that it gives a bunch of warning messages to help the user along

I refactored things a bit. Before a lot of functions were calling the code to load and parse project.clj, now it's being parsed once and passed around.

eginez commented 7 years ago

looks good. Happy to take it. Would you be able to resolve the conflicts? I think taking your previous patch might have caused some of them, you should be able to rebase from master and update the PR Thanks for again for contributing

plexus commented 7 years ago

I expected they would conflict. Should be good to go now!