Switch from urllib2 to python-requests

egirault / googleplay-api

Google Play Unofficial Python API - This project was a PoC and is not maintained anymore. Please feel free to fork it and improve it in any way.

879 stars 373 forks source link

Switch from urllib2 to python-requests #8

Closed kanzure closed 11 years ago

kanzure commented 11 years ago

Here's what's in here:

Switch from urllib2 to python-requests (hooray!)
pep8, formatting, whitespace, tab crusading, dos2unix
Move copied functions into a shared file
Make the config file complain loudly (but honestly this needs to be refactored completely, why is there a config file in a library anyway)
basic .gitignore
other things

kanzure commented 11 years ago

Oops, I forgot about debug mode.

egirault commented 11 years ago

Thanks a lot! I don't really like all those verify=False in all requests calls, but it seems that it complains when switched to True. Indeed, urllib3 doesn't handle SNI so the SSL connection on android.clients.google.com falls back to google.com. There are already 2 pull requests for SNI support in urllib (here and here, let's hope one will get through :) Anyway, great job.