search

eglaysher / rlvm

RealLive clone for Linux and OSX
http://rlvm.net
GNU General Public License v3.0
152 stars 26 forks source link

Multiple issues with glosses #2

Closed Polarem closed 13 years ago

Polarem commented 13 years ago

This happened in rlvm 0.09 (installed from the x86 Ubuntu package) while running an English version of Clannad FV. I reached the first hypertext gloss in the game ('kotatsu') and clicked on it, leading to the following:

1) The textbox that appeared at the top of the screen was only tall enough for ~3.5 lines of text but rlvm tried to display 4 lines, so the text "spilled" across the bottom border.

2) At that point, I couldn't advance the text anymore. The gloss text was too long to fit in the box so rlvm split it up, and the triangular "waiting for click" cursor was animating properly in the gloss textbox. However, my clicks were ignored.

I scrolled back a few lines in an attempt to get the text moving again. As I clicked through the previous dialogue, I noticed that:

3) When I caught up to the 'kotatsu' line again, the beginning of the sentence was painted yellow (the correct colour for previous text), the hypertext 'kotatsu' was highlighted purple (the correct colour for highlights), but the words after 'kotatsu' were painted white (the colour for "current" text). [Reallive.exe gets around this by NOT highlighting hypertext in previous text.]

I then tried to continue by saving and loading.

4) Unfortunately, the game remembered that the gloss textbox was open during my save. Upon loading, it displayed Tomoya's line in the GLOSS textbox. The main textbox didn't appear. The main text was short enough to fit in the gloss textbox, and the triangle was animating. However, clicking on 'kotatsu' didn't bring up the gloss text, and clicking everywhere else still didn't advance the text.

Finally, I started the game from the beginning and refused to click on the 'kotatsu'. That allowed me to proceed.

I made some screenshots, but didn't realize that github doesn't support attachments!

eglaysher commented 13 years ago

I was able to recreate the issue. Mouse input was ignored, but keyboard enter key still advanced text. (I tend to use enter instead of the mouse, hence why I didn't see this bug.) This also only occurs with Baka Tsuki's translation patch since they use a different window type from NDT's Kanon translation, which is where the bug is.

I've created Issue #3 and #4 to track the other irregularities in gloss behaviour, but I believe I've fixed the main can't click bug here.

eglaysher commented 13 years ago

Type 4 text waku shouldn't claim that it can handle mouse clicks.

Baka-Tsuki's custom rlBabel gloss handler creates a type 4 waku instead of a normal one, which breaks mouse input due to this bug. NDT used a normal window, so their gloss handlers worked without issue.

Closed by b7b440f6715fa14216533f01f1d8c67bd86c25b6