eglaysher / rlvm

RealLive clone for Linux and OSX
http://rlvm.net
GNU General Public License v3.0
150 stars 25 forks source link

rlvm_unittests fails on recMulti.1 #66

Open jbeich opened 9 years ago

jbeich commented 9 years ago

This happes both with clang36/libc++, gcc5/libc++ but not with gcc5/libstdc++. My copy of libc++ is at r224926 + r228344/r233552 bugfixes. I wonder if the issue affects OS X as well.

unknown file: Failure
C++ exception with description "ExpressionPiece::GetIntegerValue() invalid on object of type 2" thrown in the test body.
[  FAILED  ] MediumObjectPoromotion/PromotionTest.BgLayerPromotion/49, where GetParam() = ("recMulti", 1, (3, "\"file\"$\xFF\0\0\0\0$\xFF\xFF\0\0\0"), true) (1 ms)

Workaround.

eglaysher commented 9 years ago

Couldn't reproduce that with g++ 4.9.2-10ubuntu13 (I assume libstdc++), or with Apple LLVM clang-600.0.57 (I assume libc++).

If you're looking for a short term workaround, revering b1321e40090dc78d9fb1c71088ee8f79eb2cd874, ea4785714d52fcdb4def8e6fe0475c171f4e7f22 and 727f68b054f3e1cfd006fb0635e14a49924a9712 might help. And if it doesn't, that's would be really interesting. The three patches above were memory optimizations, and that exception is from that recent code.