Segmentation faults on rlvm_unittests

I'm not sure if work is still ongoing on this project or not, but I thought I'd report this nonethless.

I've managed to build rlvm on Fedora 28 and am running the tests via rlvm_unittests. However, the tests keep ending prematurely due to segmentation faults. I've tried randomizing the tests using the --gtest_shuffle flag, and have found a consistent handful of tests which end prematurely with Segmentation fault (core dumped). Here's a small selection of ones I've found; there may be more.

GraphicsObjectTest.TestColourFilter
RLMachineTest.SerializationOfSavepointValues
EffectTest.TestBase
TextSystemTest.RubyRepeats
MediumGrpTest.TestFill_0
MediumGrpTest.TestColour_3
MediumGrpTest.TestFill_2
MediumGrpTest.TestWipe
TextSystemTest.TestEmptyString
TextSystemTest.RenderGlyphOntoOneLine
TextSystemTest.TextPageResetIndentationRepeats
MediumObjectPoromotion/PromotionTest.BgLayerPromotion/24
TextSystemTest.TestEmoji

As this system is a fresh install, I haven't been able to run any games to test actual performance, though running the compiled rlvm build produces the game data selection screen as expected.

I'm including this as incidental information, but when I was attempting to compile rlvm I ran into the following error:

src/systems/base/graphics_object.cc:834:10: error: 'cerr' is not a member of 'std'
     std::cerr << "Warning: We only do immediate endings in "
          ^~~~
src/systems/base/graphics_object.cc:834:10: note: 'std::cerr' is defined in header '<iostream>'; did you forget to '#include <iostream>'?
src/systems/base/graphics_object.cc:47:1:
+#include <iostream>

src/systems/base/graphics_object.cc:834:10:
     std::cerr << "Warning: We only do immediate endings in "
          ^~~~
scons: *** [build/release/src/systems/base/graphics_object.o] Error 1
scons: building terminated because of errors.

I followed the possibly unorthodox suggestion in the error message and added the line #include <iostream> to the top of src/systems/base/graphics_object.cc, after which I could compile the program just fine. I don't know if this is related to the unit tests failing, but I thought I should report it as an oddity nonetheless.

As a warning, I'm pretty unskilled with the finer points of developing/compiling software; I can follow instructions to install dependencies, enable logfiles, do minor editing of makefiles and sources etc., but otherwise am fairly dumb. Please let me know if you need any more specific information on the problem, my configuration, etc.

eglaysher / rlvm

Segmentation faults on rlvm_unittests #84