search

eglaysher / rlvm

RealLive clone for Linux and OSX
http://rlvm.net
GNU General Public License v3.0
150 stars 25 forks source link

Make it build and pass unittests on my machine #96

Closed xtsm closed 1 month ago

xtsm commented 1 month ago

There were some minor compilation errors and failing unittests. One test was most likely failing because of https://github.com/google/googletest/issues/705, I've updated gtest and gmock, now it's green. Another couple of tests were failing because of the undefined iteration order for unordered_map. Also there was a hack for Apple builds that was probably supposed to fix that test by replacing the container with regular map. I've moved the hack to testing code and made it more reliable.

(This PR can be splitted, the commits are more or less independent.)

eglaysher commented 1 month ago

(It will be a few more days until I can review this patch. Sorry.)

eglaysher commented 1 month ago

Read everything. Thank you. I can't actually build anything right now (I don't have an ubuntu machine anymore and my mac isn't set up for development), but everything here makes sense so I'm just going to go ahead and merge this.

xtsm commented 1 month ago

(btw probably fixes #66 and #84)