search

eglia / ff-oc-passwords

A Firefox add-on to access passwords stored in an ownCloud.
MIT License
8 stars 3 forks source link

Plugin reports 0 logins in database #30

Open abishai opened 7 years ago

abishai commented 7 years ago

Periodicaly I try to use this plugin, I started this maybe year ago, however it is not working. During this period I tried different versions of FF and OS (Linux, Windows, FreeBSD), different version of *cloud (it was Owncloud, now it's NextCloud 10.0.1) however the result is the same. And I don't understand why.

It reports 0 passwords in database, reacts on logins (asks if I want to save password, actually creates it), but looks like it is not reading them.

I tried but failed to add debug code to plugin sources (am I need to sign it somehow or package?), so I'm writing this issue.

I tried to run requests via curl and what I got:

  1. /apps/passwords/api/0.1/version 20-beta6
  2. apps/passwords/api/0.1/passwords {"0":{"id":1,"user_id":"abishai","loginname":"","website":"github.com","address":"","pass":"2f98a21319a7ca6e40fb6786f1e882c43f9295737fcf9e1a58b9866b28edbf8a37d63187c54addb345e8ec2f79d0e01964d2263fde1c02b9bfe0d35d8b3d692e51921d322d9e9c6d00bc185c041cc7f0d04118a8873839957f225a726e9b5ab01fb942a670273f4659a29aab0665ea0512733cfd9970eb72e72fc273139bd2f381d24c9d8b01a3d4756a2dea004d150dc6f609e50e2d5815c0dc760f0976538167e2e565d27d7c73b3a10f90448803361d8adefe425c3141f3c90c25d5a079f002854e7235bcaa07","properties":"840149da374783e93598e3b94251aee15a8df6e75b42d6e9a65bf4812384c9b831ecfc44a19cd9678d60890c12477f5ff0bf0d0071f6cb15b19fd22e433cedfffe44bf56fe21e8b5cf9e995031d478ea4a96744d18ac4ecee0125654e0d9c825511ba15902a677a8e06da40c13fca35643c7c56677a3e059cefe098786908bb4ce5eba2de56f81fd0a168a136ee3a8039b620b6cd2094864730b7f7841ecb20af9fac7aca8e10ebd635bda55b63c9781f11d7cf71fc743ef815129a257f3901edb526f5500bf8b40a19162872cf6b32859851b72a300d5c22352860a51d115d06558f985868ef2bd25aab903bf591dbf683e375cd08723ef1b3bd209da6a178890dfa8f8a42e15b05e6ca35d1699f168edc6e17ee54bc3f2caea47ce4667eb59c79cfc64006b23dc86616276b2d9f57b515a4f800bbab843c623e1ebc652082a13e6186f85bae1b7ea160a693a0c4f06f4eb11b0aea7587716e2a98ce97a53d9e149564446b638e538dd521036d42c1ce228ba93403010f31a84c935cf9307816b65be3eb05c8f06","notes":"","creation_date":"1970-01-01","deleted":false},"1":{"id":2,"user_id":"abishai","loginname":"","website":"github.com","address":"","pass":"foobar","properties":"\"loginname\" : \"abishai\", \"address\" : \"https:\/\/github.com\/login\", \"strength\" : \"1\", \"length\" : \"6\", \"lower\" : \"1\", \"upper\" : \"0\", \"number\" : \"0\", \"special\" : \"0\", \"category\" : \"\", \"datechanged\" : \"2017-01-08\", \"notes\" : \"\"","notes":false,"creation_date":"1970-01-01","deleted":false},"2":{"id":0,"user_id":"quik","loginname":null,"website":"quik","address":null,"pass":null,"properties":null,"notes":null,"creation_date":null,"deleted":false},"4":{"properties":false,"notes":false,"pass":false},"5":{"properties":false,"notes":false,"pass":false}}

json contains 2 test (incorrect) passwords for github - one created manually, another is created by ff-oc-passwords during attempt to log in. I can provide test login.

eglia commented 7 years ago

The first entry in your database is not decrypted which is a bug in the ownCloud app, see fcturner/passwords#298

The second entry on the other hand seems to be valid. Is there an error in the browser console? (CTRL+SHIFT+J)

abishai commented 7 years ago

TypeError: this._recipeManager is null LoginManagerParent.jsm:185:9 TypeError: browser is null nsLoginManagerPrompter.js:806:9 NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: [JavaScript Error: "browser is null" {file: "resource://gre/components/nsLoginManagerPrompter.js" line: 806}]'[JavaScript Error: "browser is null" {file: "resource://gre/components/nsLoginManagerPrompter.js" line: 806}]' when calling method: [nsILoginManagerPrompter::promptToSavePassword] LoginManagerParent.jsm:532:0

abishai commented 7 years ago

That error was when I hit save in Settings. However, no errors when I use refresh button.

abishai commented 7 years ago

the firsrt entry fix: https://github.com/fcturner/passwords/pull/304