eglia / ff-oc-passwords

A Firefox add-on to access passwords stored in an ownCloud.
MIT License
8 stars 3 forks source link

Support for Nextcloud-comaptible Passwords app fork? #38

Open e-alfred opened 7 years ago

e-alfred commented 7 years ago

Hello,

there is a fork of the passwords app now that supports Nextcloud 12:

https://github.com/marius-wieschollek/passwords

Is it possible to support this? For now the extension basically works well.

marius-wieschollek commented 7 years ago

Actually, I have the same question. I do maintain the fork mentioned above. But this only makes sense to me, if i can use the Firefox Addon.

e-alfred commented 7 years ago

Well, this app is not a Webextension, so it won't work with Firefox from version 57 onwards (which will be soon).

This is probably just another reason for abandoning this app...

pafcioooo commented 7 years ago

I am another user of @marius-wieschollek fork of passwords app that I use with this extension, so I am voting of moving this app to FF 57 - though I do not know how much work it requires...

marius-wieschollek commented 7 years ago

I'm just letting you know that i am working on a Webextension here. As of right now it is not on AMO, so you need to load it manually. Also it does not automatically fill in the passwords, just copy to clipboard. But i hope i will get this done until Sunday.

pafcioooo commented 7 years ago

But i hope i will get this done until Sunday.

@marius-wieschollek are an magician? ;-)

I am going after it, THANK YOU:-)

e-alfred commented 7 years ago

@marius-wieschollek Nice work, but if its a Webextension, you could put it on the Chrome/Opera web store too. That way the new Passwords app would already support a lot more browsers than just Firefox.

marius-wieschollek commented 7 years ago

@e-alfred Well it turns out, that the Firefox api uses promises while the Chrome api uses callbacks for return values. So they are not absolutely compatible and it will take some time until i have a cross browser compatible extension.

marius-wieschollek commented 7 years ago

I'm waiting for the review: https://addons.mozilla.org/de/firefox/addon/nextcloud-passwords/ Inserting passwords works now as well :D

marius-wieschollek commented 7 years ago

@pafcioooo @e-alfred I just published the latest version on AMO: https://addons.mozilla.org/de/firefox/addon/nextcloud-passwords/. The git is at https://github.com/marius-wieschollek/passwords-webextension. All major features are included. When I'm done rewriting the backend of the passwords app, I will add more features and more browsers in the extension.

pafcioooo commented 7 years ago

@marius-wieschollek where should we file issues for the extension?

marius-wieschollek commented 7 years ago

@pafcioooo It is up to you. You can use the repository here on GitHub ore the one on my private GitLab. Whichever is more convenient for you.