search

egnyte / egnyte-dotnet

.NET SDK for the Egnyte Public API
5 stars 17 forks source link

Support for Tasks API #15

Closed lroos closed 4 years ago

lroos commented 4 years ago

I've included support for Tasks API endpoints and somewhat followed the existing code conventions. The new unit tests are all green and I've implemented the client in a test project. A lot of this (especially JSON serialization areas) can be done a lot nicer but will leave refactoring for another day. I would have added this to one of the .NET Standard forks but I am currently needing it in a .NET 4.x project so this is my priority.

mikuam commented 4 years ago

Thanks @lroos, very good changes. I agree that handling JSON can be done better, but let's leave it for later improvements. As for supporting 4.x projects. I'm going to implement version 2 of this API for .NET Standard 2.0. Would that work for you? Would your project benefit from this change?

lroos commented 4 years ago

As for supporting 4.x projects. I'm going to implement version 2 of this API for .NET Standard 2.0. Would that work for you? Would your project benefit from this change?

Unfortunately I'm using the library from UiPath which is based on some deprecated Windows Workflow Foundation components, so the UiPath Studio IDE doesn't actually support .NET Standard libraries :( It turns out it also has trouble with referencing classes in the PCL library as well. So I'm working off a branch where I've turned the Api project into a Shared project and referencing it from a .NET Framework class library. I think the ideal setup for v2 would be one where you have multiple projects targeting different platforms and pack all the output assemblies into the same NuGet package.

mikuam commented 4 years ago

Llewellyn,

I learned that with the new Sdk project structure, I can support more than one framework. I'm planning to support .net standard 2.0 and .net framework 4.6.1. Would that work for you?

Regards, Michał

śr., 12 sie 2020 o 12:03 Llewellyn Roos notifications@github.com napisał(a):

As for supporting 4.x projects. I'm going to implement version 2 of this API for .NET Standard 2.0. Would that work for you? Would your project benefit from this change?

Unfortunately I'm using the library from UiPath which is based on some deprecated Windows Workflow Foundation components, so the UiPath Studio IDE doesn't actually support .NET Standard libraries :( It turns out it also has trouble with referencing classes in the PCL library as well. So I'm working off a branch where I've turned the Api project into a Shared project and referencing it from a .NET Framework class library. I think the ideal setup for v2 would be one where you have multiple projects targeting different platforms and pack all the output assemblies into the same NuGet package.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/egnyte/egnyte-dotnet/pull/15#issuecomment-672778939, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2MZN7WET7UCKZVVNYSJI3SAJSFDANCNFSM4O3CMM3Q .

lroos commented 4 years ago

I think that would be perfect