search

egnyte / egnyte-js-sdk

Javascript SDK to work with Egnyte Public APIs
15 stars 16 forks source link

open requestTokenPopup in a real popup instead of tab #1

Closed slunecniborecek closed 7 years ago

naugtur commented 8 years ago

Hi and thanks for contributing. I'd rather make it an option to let you pass the argument to window.open. Would that work tor you?

slunecniborecek commented 8 years ago

Sure it would. Are you going to implement it or should I? :) Thanks

naugtur commented 8 years ago

I can get down to it next week, so if you have an urgent need for it I'd recommend you implement it. If not, I'll do it next week, release a version and let you know when it's available.

my initial idea was:

requestTokenPopup = function (callback, denied, recvrURL, windowOptionsString)
slunecniborecek commented 8 years ago

well, I personally don't like this 'put there one more argument' pattern, instead I would change that to function(config){}... But I understand you need to keep the compatibility

naugtur commented 8 years ago

Next major release will need to have breaking changes in requesting tokens, as we're moving away from the iframe version, so I'll be able to clean this up.

slunecniborecek commented 8 years ago

cool, will keep the modified version in our project as it works the way we want & switch later when ready. Thanks