egocarib / EnchantmentFramework

SKSE Plugin for Skyrim
6 stars 5 forks source link

Multiple Enchantment Effects #2

Closed egocarib closed 10 years ago

egocarib commented 10 years ago

As Gruftlord reported on the nexus, enchantments with more than one effect will only have their first effect scaled when the player makes an enchantment using them. The main example is Chaos Damage -- since only its Shock damage actually gets increased at the enchanting table, the Fire and Frost effects stay at their base magnitude of 10.

This might be fixable for chaos damage specifically, though trying to fix it for every enchantment would be tricky, mainly because of the complexities introduced by multiple enchantments on a single item, as discussed in #1 -- I wouldn't know whether effect 2 was a secondary effect added from the Extra Effect perk or if it was a secondary effect of a single enchantment (as in the case of fiery soul trap/chaos damage/etc), so it would be hard to know whether to scale it or not.

The other thing to keep in mind is that I wouldn't want to fix effects whose magnitudes are included in enchantment descriptions, since it would be confusing to see them at one magnitude while enchanting, and then changed afterward (Chaos damage only shows the strength of the shock enchantment, which is the one that changes).

egocarib commented 10 years ago

Possible workaround:

somehow "mark" all the secondary effects of base enchantments when the player activates the enchanting table. For instance, increase their magnitude by 0.01 (since they usually have whole number magnitude) -- or give them an area value, since that shouldn't be used by any weapon enchantments. (experimenting with CK, even when magic effect has an area, area still shows up as zero in the enchantment). [could just increase area by a ridiculous amount otherwise - so it's clear that it's been edited]

I could then change them all back after exiting the table, but it would allow me to detect where one effect or set of effects from a single enchantment "ends" and the next one begins, if it's a multi-enchanted item.

However, this would require me to start tracking items as they are disenchanted, instead of just after the player leaves the table -- in case newly learned enchantments while at the table are also used to create a new enchantment (unless I just "marked" all weapon enchantments before entering the table, in case player learned any of them while there <- this would probably be easiest, actually)

egocarib commented 10 years ago

Chaos Damage taken care of, the rest will have to wait until I can figure out how to hook and alter the crafting menu display for charge meter adjust.