egoist / docute

📚 Effortless documentation, done right.

https://docute.egoist.dev

MIT License

3.8k stars 427 forks source link

Css helpers shorthand implementation #152

Closed ulivz closed 6 years ago

ulivz commented 6 years ago

Summary

Finished https://github.com/egoist/docute/issues/145, two main points:

Add fenced container syntax for css helper by using markdown-it-container
Migrate the style from v3.

Snapshot

ulivz commented 6 years ago

@egoist Just hold on this PR, thanks. I have made a standalone test for using <p class='xxx'> instead of <div>, and it looks good. I need to do some investigation for that.

https://codepan.net/gist/0d29a35d61822f769c73351582a65b99

ulivz commented 6 years ago

@egoist It seems that this PR can be reviewed now.

egoist commented 6 years ago

Deploy preview for docute failed.

Built with commit 5ca627950992d0be594f2aa9bbdbfd12f96931fc

https://app.netlify.com/sites/docute/deploys/5ac42510be40f105917d2938

ulivz commented 6 years ago

I have merged special-blockquotes into this branch, so this branch shouldn't be merge util its dependence merged.

FYI, I have renamed the css-helpers to message-containers since its usage(without HTML) looks more like a container.

So you can view the entire change at the link your lovely robot commented above :grin:

egoist commented 6 years ago

seems we can simply convert ::: warning ::: info ::: alert ::: success to <div class="message $type">...</div> to reuse styles from #157

ulivz commented 6 years ago

Not sure if the naming of message container or colors is OK for you. so this is up to you to decide.

Weekend is done, Oh my gad.

ulivz commented 6 years ago

@egoist Cool, just let me to work for it.