egoist / docute

📚 Effortless documentation, done right.
https://docute.egoist.dev
MIT License
3.81k stars 427 forks source link

can't jump to encoded character hash #212

Closed mcdoyaji closed 5 years ago

mcdoyaji commented 5 years ago

I clicked [sidebar](./options#사이드바) hash link.

but, url link encoded.

sidebar

so I Got result below.

×
Unhandled Rejection (SyntaxError): Failed to execute 'querySelector' on 'Document': '#%EC%82%AC%EC%9D%B4%EB%93%9C%EB%B0%94' is not a valid selector.
VueComponent.jumpToHash

so, I edit jumpToHash() to get Decoded string.

    jumpToHash() {
      const {hash} = decodeURI(this.$route)
      if (hash) {

now, no more '9C%EB%B0%94' is not a valid selector. but still It's not jump to hash position.

I think that jump.js can't recognize hash position.

egoist commented 5 years ago

Yeah we need to decodeURIComponent, PR welcome.

mcdoyaji commented 5 years ago

ah-ha. const hash = decodeURI(this.$route.hash) works.

I'll PR soon. Thanks to make this nice program!

egoist commented 5 years ago

:tada: This issue has been resolved in version 4.13.6 :tada:

The release is available on:

Your semantic-release bot :package::rocket: