search

egoist / docute

📚 Effortless documentation, done right.
https://docute.egoist.dev
MIT License
3.8k stars 427 forks source link

feat: improve css in print view #219

Closed kevgathuku closed 5 years ago

kevgathuku commented 5 years ago

Fixes #215

Print view after applying changes in this PR: image

egoist commented 5 years ago

/cc @chanjsq

egoist commented 5 years ago

Can you remove the left and right margin as well? seems we don't need that in print view

kevgathuku commented 5 years ago

Sure. I'll fix that too @egoist

kevgathuku commented 5 years ago

I've removed the margins. Here's how it looks now cc @egoist

image

egoist commented 5 years ago

the margin in header in unnecessary too, ~maybe we don't even need the header? (@chanjsq)~

egoist commented 5 years ago

Maybe we should show header nav in print view.

kevgathuku commented 5 years ago

the margin in header in unnecessary too, maybe we don't even need the header? (@chanjsq)

I've removed the left margin in the header and updated the image. Is this the header margin you meant?

egoist commented 5 years ago

:tada: This PR is included in version 4.14.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

kevgathuku commented 5 years ago

Nice. It's looking much better now 🚀 Thanks @egoist