egoist / docute

πŸ“š Effortless documentation, done right.
https://docute.egoist.dev
MIT License
3.8k stars 427 forks source link

fix: tweak header and pager in print view #241

Closed mrtoorich closed 5 years ago

mrtoorich commented 5 years ago

Fixes #227

egoist commented 5 years ago
屏幕快照 2019-06-13 δΈ‹εˆ10 51 19

the first page has a weird top padding.

mrtoorich commented 5 years ago

I removed the weird top padding by reducing the padding-top of .Main by --header-height.

egoist commented 5 years ago

hmm I think there should be no padding at all?

mrtoorich commented 5 years ago

Yes, using padding-top: 0 is better:

I will fix this.

mrtoorich commented 5 years ago

Done. The top padding is now completely removed.

egoist commented 5 years ago

welp maybe we can just unset position: fixed for header, it's weird if we don't show header at all πŸ˜…

mrtoorich commented 5 years ago

Good solution. πŸ‘

mrtoorich commented 5 years ago

A little more discussion: should .header-nav hide or not?

egoist commented 5 years ago

it's fine to keep it I guess, as long as it doesn't break anything.

mrtoorich commented 5 years ago

I think .header-nav can be removed, because the header nav holds commonly used tools, e.g. search bar, help buttons, notice buttons, etc.

But I also agree with your thoughts.

I will keep it.

egoist commented 5 years ago

we do have a search bar, it should be hidden then

egoist commented 5 years ago

btw, do you actually print the PDF in papers or just need the PDF file? header nav will still be useful when you're viewing the PDF file.

mrtoorich commented 5 years ago

Both. When making PDFs, it looks nice. But when printing in papers, it used too much papers, because the margins and the line height are too large. It can be optimized, but my design sense is poor.

mrtoorich commented 5 years ago

Another non-topic discussion: when using projector, the text is too small to be seen. I often use command + + to increase the text size. 🀣

egoist commented 5 years ago

:tada: This PR is included in version 4.21.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: