search

egoist / docute

📚 Effortless documentation, done right.
https://docute.egoist.dev
MIT License
3.8k stars 427 forks source link

embeds #246

Open janat08 opened 5 years ago

janat08 commented 5 years ago

fix #205 I added this into core plugins, and made a separate page in guides for docs.

It doesn't parse titles into sidebar since you'd have to sort out the order in which they should come, which the documentation will note as much. The controls for video/audio is a boolean attribute therefore it can't be overridden with additional attributes like controls='false', and it is set on by default.

janat08 commented 4 years ago

Please merge and reward

janat08 commented 4 years ago

@egoist?

janat08 commented 4 years ago

@egoist

janat08 commented 4 years ago

@egoist wouldn't mind just the bounty, pr review whenever you feel like it. Its been half a year.

egoist commented 4 years ago

Actually we only need to use embed to inline external code, for iframe audio you can directly write HTML. See https://github.com/egoist/docute/issues/205#issuecomment-475793496

janat08 commented 4 years ago

Updated, please reward money at very long last.

janat08 commented 4 years ago

I can't at all tell whats up with the circleci, as it loads a loader with null>null>null for the workflow. I'll go fix another PR to see if youll deign to reward me with that one.

janat08 commented 4 years ago

So the circleCI is giving crap during linting that has nothing to do with my code, and doesn't even show up on local machine.

janat08 commented 4 years ago

?

janat08 commented 4 years ago

?