egoist / dum

An npm scripts runner written in Rust.
MIT License
1.52k stars 28 forks source link

Fix root dir compatibility issue on windows #21

Closed beetcb closed 2 years ago

beetcb commented 2 years ago

https://github.com/egoist/dum/blob/5e37d3763363402ae4b15c91ac53d81a1e4c88ec/src/lib.rs#L37

On windows, this comparison can never be true, so rust will panic with an unhelpful message:

thread 'main' panicked at 'called `Option::unwrap()` on a `None` value' ...

Fixed version of panic message:

thread 'main' panicked at 'no package.json' ...
egoist commented 2 years ago

Great, I can merge it once the conflicts get resolved.

beetcb commented 2 years ago

wrong push, sorry 😂, I'll revert it