search

egoist / eme

Elegant Markdown Editor.
https://egoist.sh/eme
MIT License
2.05k stars 151 forks source link

OSX: Open with #74

Open irrelevantat opened 8 years ago

irrelevantat commented 8 years ago

When opening a file on OSX with "Open with" the file does not open at all.

OSX: 10.11.6 Eme: 0.8.0

iqtoun7szu

irrelevantat commented 8 years ago

@egoist I'd be motivated in improving the open-with logic and make a pull request. Interested?

egoist commented 8 years ago

Sure, I'd appreciate it. I've updated the code base to use Vue 2, make sure to pull --rebase before sending PR 😋

// Edit: reverted to vue 1, there're some bugs with vue 2 and vuex 1 😓

daviewales commented 7 years ago

@Sebastian-Hojas Have you made any progress on this?

irrelevantat commented 7 years ago

No, unfortunately I don't have time for this at the moment.

elite-sheep commented 4 years ago

@Sebastian-Hojas I have a fix on this issue. Please refer to my PR above. There is still a small edge cases. After we close all windows and try to use open-with, we will get no result. It is because there is a bug in electron 2.x that all 'close' events for windows are ignored. I will try to fix this after we upgrade EME to electron 7.x+.