Addressed Cheerio Dependency Issue and Link Formatting - Githubissues

egoist / gh-pinned-repos

API service for retrieving pinned repos on GitHub.

https://gh-pinned-repos.egoist.dev

MIT License

116 stars 17 forks source link

Addressed Cheerio Dependency Issue and Link Formatting #23

Closed aymenae closed 7 months ago

aymenae commented 9 months ago

Pull Request Summary

Changes Made

Fixed the way the repository link is constructed by using template literals and applying the trim() method to remove leading and trailing whitespaces.
Fixed the image link construction by using template literals and applying the trim() method to remove leading and trailing whitespaces.
Resolved the Cheerio dependency issue by updating the import statement for Cheerio to the correct version (1.0.0-rc.12).

Context

See screenshots

Testing

Runs locally, when hosted & linked to existing project using gh-pinned-repos the links worked as opposed to using current version

Screenshots (if applicable)

current version; https://snipboard.io/jXabd6.jpg this PR; https://snipboard.io/LdwFVj.jpg

This is my first PR, let me know if i missed anything / could do anything better. Thanks!

socket-security[bot] commented 9 months ago

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
deno	0.1.1	filesystem, environment	`+4`	167 kB	youngoat