feat: get stars and forks as number

egoist / gh-pinned-repos

API service for retrieving pinned repos on GitHub.

https://gh-pinned-repos.egoist.dev

MIT License

116 stars 17 forks source link

feat: get stars and forks as number #7

Closed Kapcash closed 3 years ago

Kapcash commented 3 years ago

I propose to return the number properties (stars and forks) as number :) Currently, it's returned as string if there is a value, or 0 (so it's mixing up the types).

If a weird value is passed to parseInt, it will return NaN and be defaulted to 0.

Note: I just hope nobody's relying heavily on this service because it's kinda a breaking change 😬

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/egoist/gh-pinned-repos/FhEXMjf9rLRU2FuBhtDuwgtjUDQM
✅ Preview: https://gh-pinned-repos-git-fork-kapcash-master-egoist.vercel.app

egoist commented 3 years ago

closing since it's fixed by #10, thanks