search

egoist / hack

⛷ Dead simple CSS framework.
https://hackcss.egoist.dev
MIT License
2.6k stars 140 forks source link

align ol gt 10 #59

Closed ghost closed 6 years ago

ghost commented 7 years ago

fixes an alignment issue for ordered list > 10

resolves #51

screen shot 2017-09-24 at 2 14 15 pm

@egoist

egoist commented 7 years ago

hmm does this work everywhere 😅

ghost commented 7 years ago

@egoist lmk where I should test. I built locally and checked two of the theme variants. It's an improvement over the current issue linked. 👍

egoist commented 7 years ago

what about >= 100? does this work?

ghost commented 7 years ago

what about >= 100? does this work?

No. Nor would 1000 if 100 were added given current design. This pull addresses the immediate need in the issue and adds yarn.

ghost commented 7 years ago

@egoist After some additional testing I fixed a bug where unordered lists were also receiving the style update for list sizes > 9. This is an incremental improvement. Could I get an emoji to rebase and merge into master?

ghost commented 6 years ago

Merged. Ready for release.

ghost commented 6 years ago

@egoist time to release a patch from master, which includes these changes?

egoist commented 6 years ago

Published, sorry I totally forgot about this 😅