Open ComLock opened 2 months ago
Might be related to https://github.com/evanw/esbuild/issues/2382
Hmm, even downgrading to tsup 6.7.0 and esbuild 0.17.9 didn't help. Perhaps it's another module.
The externals change came in https://github.com/evanw/esbuild/releases/tag/v0.16.0, but even downgrading to 0.15.8 didn't help.
Ah, tsup had it's own copy of esbuild under node_modules/tsup/node_modules/esbuild.
I had to downgrade to tsup 6.5.0 so an old enough version of esbuild was used (0.15.8) then it worked.
So I guess the problem is in esbuild from version 0.16.0.
I guess this ticket should be moved to esbuild then?
This https://github.com/enonic/starter-react4xp/blob/16a350485827d80be28aea384c3367d251edac5b/package.json#L94
Runs this: https://github.com/enonic/npm-react4xp/blob/5911b76ea605c5595148390f6054dc11b781969c/package.json#L114
Which finally runs this: https://github.com/enonic/npm-react4xp/blob/5911b76ea605c5595148390f6054dc11b781969c/package.json#L127
Which is:
Which will give this error:
Editing tsup.config.client.ts changes nothing, it seem's it doesn't even attempt to read the file.
If I rename /private/tmp/myproject/node_modules to /private/tmp/myproject/whatever
Then cd /private/tmp/myproject/whatever/@enonic/react4xp/ I can run npm install And now npx tsup --config tsup.config.client.ts works.
So it seems to mark everything under "node_modules" as external?
Upvote & Fund