search

egoist / tsup

The simplest and fastest way to bundle your TypeScript libraries.
https://tsup.egoist.dev
MIT License
9.29k stars 223 forks source link

feat: add `experimentalDts.only` #1237

Open aryaemami59 opened 1 month ago

aryaemami59 commented 1 month ago

This PR:

codesandbox[bot] commented 1 month ago

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders
Open Preview

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tsup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2024 5:07am
pkg-pr-new[bot] commented 1 month ago

Open in Stackblitz

pnpm add https://pkg.pr.new/egoist/tsup@1237

commit: a6cda79

ocavue commented 1 month ago

I kind of don't want to add another experimental CLI option. To be honest, I'm not happy with the current @microsoft/api-extractor-based --experimental-dts implementation either, since it requires an ugly _tsup-dts-rollup.d.ts file. I'd prefer to find a more suitable solution before putting in extra effort on top of it.

ocavue commented 1 month ago

I really appreciate your recent work around dts. I just need some more thinking before merging them.

aryaemami59 commented 1 month ago

@ocavue It's okay I understand. I'm trying to do whatever I can to help fix experimentalDts, it has a lot of potential, it just needs work, and I thought maybe this could be a start. I'm still going to try and see if I can remove _tsup-dts-rollup files, I think if We can accomplish that it'll solve a lot of issues related to experimentalDts.

aryaemami59 commented 2 weeks ago

@ocavue Do you mind if I work on improving experimentalDts,maybe try to come up with an implementation that does away with _tsup-dts-rollup files?