egoist / tsup

The simplest and fastest way to bundle your TypeScript libraries.
https://tsup.egoist.dev
MIT License
9.25k stars 218 forks source link

bug: MinifyOptions re-exported from terser by tsup include invalid typings when processed by rollup-plugin-dts #834

Closed favna closed 1 year ago

favna commented 1 year ago

After updating tsup to to v6.6.0 our build is failing when running a general type checking with --noEmit because the typings of tsup re-export the typings of terser which in turn are incorrectly parsed by rollup-plugin-dts. The error log can be found here: https://github.com/sapphiredev/shapeshift/actions/runs/4156157046/jobs/7189739909 and/or https://github.com/skyra-project/char/actions/runs/4156157083/jobs/7189740023

I know the root cause here is either terser or the dts plugin, but I also don't think either of those libraries can really realistically fix the issue so I'm hoping you can fix it on the tsup side.

For now I can apply a yarn patch to circumvent the issue, but that is less than ideal.

github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version 6.6.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

favna commented 1 year ago

Hi, thanks for the quick resolution, but that change doesn't appear to have fixed the issue:

image
egoist commented 1 year ago

try 6.6.2

favna commented 1 year ago

Can confirm the issue has been resolved with v6.6.2, thanks again!