`external` option ignored for paths that are tsconfig paths - Githubissues

egoist / tsup

The simplest and fastest way to bundle your TypeScript libraries.

https://tsup.egoist.dev

MIT License

9.2k stars 220 forks source link

`external` option ignored for paths that are tsconfig paths #917

Open dodas opened 1 year ago

dodas commented 1 year ago

Hey! When using the external option together with skipNodeModulesBundle: true, the paths that are listed in tsconfig paths are not treated as external and are getting bundled instead. This if branch passes as truthy and so it doesn't get to the external check below it.

Is this intended? Thanks!

Upvote & Fund

We're using Polar.sh so you can upvote and help fund this issue.
We receive the funding once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog.

Fund with Polar

DanielGiljam commented 1 year ago

I've noticed this behavior as well.

I doubt it's intended.