egoist / vue-isomorphic-starter

Vue server-side rendering in real life. ~(≧▽≦)/~
https://vue-isomorphic-starter-qxtbclbzmw.now.sh/
146 stars 13 forks source link

not work in latest node version #7

Closed qianhuang closed 8 years ago

qianhuang commented 8 years ago

I try it in windows. It works well with node 6.4. But I cannot load a page in browser after I upgrade to node 6.5 or latest 6.6.

egoist commented 8 years ago

What error occurs?

qianhuang commented 8 years ago

No matter in edge, chrome or firefox, the browser keeps loading. The page is visible, but not in correct style. And at this time, if I try to have a look at the source of the page, it is blank. After a long time, after the browser is no long in loading, if I press F12 in chrome, there will be an error “net::ERR_INCOMPLETE_CHUNKED_ENCODING”showed in it.

I met this problem on my win 10 laptop. I notice it works well on other computer, so I compare the versions of the node.js installed on them. I found, when I roll back the node.js version to 6.4.0 on my laptop, the problem gone.

ncwhale commented 8 years ago

Verified when use node v6.5.0 and v6.6.0, this project does not work.

Works with v6.4.0.

OS: Mint linux 18.

egoist commented 8 years ago

Pretty sure it's introduced by https://github.com/egoist/vue-isomorphic-starter/commit/e34ea6e0f99d714fdd341b42677af48e3973db41 , it works after git reset --hard 47b9b376f7dd93ffec, I would try to fix it, maybe @LucasIcarus can help too 😆

LucasIcarus commented 8 years ago

@qianhuang @ncwhale #8 replace the render-stream style resolve the bug.. tested in node 6.6.0 windows 10

@egoist do u mind give me an access for this repo?

egoist commented 8 years ago

@LucasIcarus I've added you the the collaborators, cheers 🍻

egoist commented 8 years ago

Closed by https://github.com/egoist/vue-isomorphic-starter/pull/8