Closed benyanke closed 6 years ago
Hey @benyanke! What else needs to be done to consider this ready for action? I would love to have this functionality available in the plugin π
Maybe we could integrate https://date-fns.org/v1.29.0/docs/distanceInWordsToNow to save a lot of works π
Great idea @egoist π
Do you also plan on replacing the βregularβ date ago with date-fnsβ distanceInWords?
@rijkvanzanten yeah sure
There is one slight problem with the date-fns
implementation of distanceInWordsToNow
: it doesn't use the actual word ago
in the output. E.g. 2 days ago
in vue-timeago is rendered as 2 days
when using distanceInWordsToNow
.
@rijkvanzanten there's an option for that in distanceInWordsToNow
btw this landed in v4 π
Oh nice! Didn't see that in the docs π
Thanks for your awesome OSS work @egoist! β€οΈ
Looks like this is resolved, but is there anything else needing to be done to use it, or will it automatically use before/after when specifying :since
?
@benyanke Automatically based on :since
π (Just tried this in my app + it's in the example)
Awesome - I must be hitting another bug then.
far from done, but a first step showing an example of what future date handling could look like.
Looking for thoughts to see if I should continue.
Tag #55