egold555 / CorpseReborn

Port of spigot Corpses plugin that I ported to version 1.7.10-1.16.4
https://www.spigotmc.org/resources/corpsereborn.29875/
27 stars 22 forks source link

The "jacket" part of the skin is missing from all corpses in 1.8.8 servers #81

Open KabanFriends opened 5 years ago

KabanFriends commented 5 years ago

CorpseReborn doesn't render jacket part of the skin in 1.8.8.. this actually causes some problem in my server because some people have naked body skin so other people sees it... (we know it's in "game" but they don't like to see it) for this reason my friend can't use this plugin for his stream and other things...

please fix this!

I also tested this in spigot 1.8 and the problem didn't happen in 1.8. but then most plugins don't work well in 1.8 (like Skript and its script codes which accesses CorpseReborn API)

image screenshot (this is not 1.14 I just used 1.14 texture for 1.8)

egold555 commented 5 years ago

Hi. Can you please do "/cr dump" and send me the pastebin link? That will help me further debug your issue you are having.

On Tue, Jul 23, 2019, 2:15 AM KabanFriends notifications@github.com wrote:

CorpseReborn doesn't render jacket part of the skin in 1.8.8.. this actually causes some problem in my server because some people have naked body skin so other people sees it... (we know it's in "game" but they don't like to see it) for this reason my friend can't use this plugin for his stream and other things...

please fix this!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/egold555/CorpseReborn/issues/81?email_source=notifications&email_token=AAW4J53XLCRQFKRWMGGKSVTQA3D2LA5CNFSM4IGB5KRKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HA3W3AA, or mute the thread https://github.com/notifications/unsubscribe-auth/AAW4J56IYAP7PIEP7ACG5HDQA3D2LANCNFSM4IGB5KRA .

KabanFriends commented 5 years ago

Dump on my main server: https://pastebin.com/ct4YqEgJ Dump on a new server: https://pastebin.com/RRCpwVkT

I used PaperSpigot this time, but same problem happened on normal Spigot too.

KabanFriends commented 5 years ago

sorry I mis-closed the issue

KabanFriends commented 5 years ago

More info: This issue didn't happen in older version of CorpseReborn, but I can't use it because the bed doesn't spawn in Y=0 so it breaks the visual of the map, and also it kicks most players.

egold555 commented 5 years ago

On your new server, try deleting the config and corpses.yml Something is very strange with those files with almost everything being null.

What do you mean buy it breaks the map? And is there a way you can screenshot the logs on the server and client (if there are any) if when a player gets kicked? That is very strange as well and should not happen.

egold555 commented 5 years ago

And the bed has always spawned at y = 1 for as long as I can remember coding it. I don't remember changing it ever but I could be wrong, I am pretty tired this morning

https://github.com/egold555/CorpseReborn/blob/master/src/org/golde/bukkit/corpsereborn/Util.java#L218

KabanFriends commented 5 years ago

for the kick log: I've never got kicked from the server (only some of my friends get kicked) so I can't see the kick error. (Also the server is hosted by my friend so I can't check the server log)

about the bed: image the bed spawned like this in an VERY old version, so this could visually break the map (also, the skin bug didn't happen in this version)

but both two things are about VERY old version. (around 2.7) I just wanted to tell that "using old version of CorpseReborn fixes the skin bug but it cannot be used because of the visual bug of beds and player kicks"

egold555 commented 5 years ago

I would update to the latest version of CorpseReborn. I tried to replicate the skin issue but I was not successful.

KabanFriends commented 5 years ago

I'm using the latest CorpseReborn... I mean I just "tested with older version and found it that the problem doesn't happen in older versions" I'm not always using it

the issue happens on latest CorpseReborn with latest spigot build for 1.8.8