search

egonSchiele / HandsomeSoup

Easy HTML parsing for Haskell
http://egonschiele.github.com/HandsomeSoup
BSD 3-Clause "New" or "Revised" License
124 stars 20 forks source link

hspec < 1.10? #26

Closed peti closed 9 years ago

peti commented 9 years ago

Is there any particular reason why your package refuses to build with modern versions of hspec?

egonSchiele commented 9 years ago

Actually, I'm working on pushing out a new version of HandsomeSoup that will work with modern versions of hspec: https://github.com/egonSchiele/HandsomeSoup/commit/e68f4de2d90bd9d6a8d29894c530a4f76b9706a5

egonSchiele commented 9 years ago

Ok, new version of HandsomeSoup pushed!

peti commented 9 years ago

Very cool, thank you! Unfortunately, we've run into a new problem with the latest version: http://hydra.cryp.to/build/208411/nixlog/2/raw. We've upgraded to network 2.6.x in NixOS. I believe that supporting those new version is just a matter of bumping the restrictions in the Cabal file; the code shouldn't have changed. Would you mind doing that?

egonSchiele commented 9 years ago

Sadly I downgraded specifically so HandsomeSoup would work with stackage: https://github.com/fpco/stackage/issues/310

What if I add a flag as suggested here: http://hackage.haskell.org/package/network-uri

Would that work for you?

peti commented 9 years ago

Sure, if the package could support both network 2.5 and 2.6, that would be great!

egonSchiele commented 9 years ago

Does this work? https://github.com/egonSchiele/HandsomeSoup/commit/7b995154f3f10cac0496ec1a4e2468d7a5b5e7e1

You should be able to build the library with network 2.6.x like this:

 cabal install -f new-network-uri
peti commented 9 years ago

Yes, I think that does the trick. It's not even necessary to specify that flag explicitly; cabal figures that out automatically.

egonSchiele commented 9 years ago

Ok, I have pushed version 0.3.5 of this package with this fix. Sorry for the delay.