Include input parameters in ReturnContractError

egonSchiele / contracts.ruby

Contracts for Ruby.

http://egonschiele.github.com/contracts.ruby

BSD 2-Clause "Simplified" License

1.44k stars 82 forks source link

Include input parameters in ReturnContractError #215

Open beezee opened 8 years ago

beezee commented 8 years ago

Because these are runtime, I think it's way more useful to see what input produced an invalid return, considering it doesn't necessarily mean you have this error on all possible inputs.

Is this something folks agree with, or are there concerns about it?

If it would be accepted (barring any code review of course) I would be happy to open a PR

egonSchiele commented 8 years ago

Sounds good to me, send over a PR!

alex-fedorov commented 8 years ago

:+1: Sounds good to me too!

Best Regards, Oleksii Fedorov, Sr Ruby, Clojure, Crystal, Golang Developer, Microservices Backend Engineer, +49 15757 486 476

On Sat, Jan 9, 2016 at 7:06 AM, Aditya Bhargava notifications@github.com wrote:

Sounds good to me, send over a PR!

— Reply to this email directly or view it on GitHub https://github.com/egonSchiele/contracts.ruby/issues/215#issuecomment-170200693 .