search

egonSchiele / dominion

A Dominion simulator in Haskell
Other
111 stars 11 forks source link

dominion-0.1.0.4 test suite failure #10

Open peti opened 9 years ago

peti commented 9 years ago

Citing from http://hydra.cryp.to/build/875727/log/raw:

running tests
Running 1 test suites...
Test suite test-dominion: RUNNING...

integration tests
player sherlock won 1000 times
player watson won 0 times
  the stupid strategy of only buying provinces and golds should never win
player sherlock won 351 times
player watson won 649 times
  bigMoney2 should win 1.4 times as often as bigMoney
player sherlock won 579 times
player watson won 421 times
  bigMoneySmithy should win 1.4 times as often as bigMoney2 FAILED [1]

Failures:

  1) integration tests bigMoneySmithy should win 1.4 times as often as bigMoney2
       expected: True
        but got: False

Randomized with seed 1337324813

Finished in 6.4645 seconds
3 examples, 1 failure
Test suite test-dominion: FAIL
egonSchiele commented 9 years ago

Does it work if you re-run? Unfortunately the way this test is written, there's an element of randomness, so there's a chance of failure. I think long-term it would be better for me to write a deterministic test.

peti commented 9 years ago

Well, if the test fails randomly, then I'll have to remove the package from the NixOS distribution (or at least disable the test suite altogether). We can't have our volunteers and users spend their time debugging this kind if problem.

egonSchiele commented 9 years ago

That makes sense, please remove it from the distribution. Sadly this package is still a work in progress, and I haven't had much time to work on it.