egonw / SARS-CoV-2-Queries

Wikidata Queries around the SARS-CoV-2 virus and pandemic
https://egonw.github.io/SARS-CoV-2-Queries/
Other
9 stars 8 forks source link

Modelling of COVID-19 vaccines will change #43

Open lubianat opened 3 years ago

lubianat commented 3 years ago

Hello,

I raised a point in a recent discussion post about the modelling of vaccines on Wikidata: https://www.wikidata.org/wiki/Wikidata_talk:WikiProject_COVID-19#Ontological_organization_of_vaccines

In short, I'm planning to model the different types of vaccines as types of vaccine, and not "vaccines" themselves. I think this might break the vaccines section. A small change (P31 to P279) in the SPARQL query would provide support.

I'd happily open a pull request with the updated query. Should I?

egonw commented 3 years ago

Yes, please go ahead!

lubianat commented 3 years ago

I've tried opening a PR, is that format correct?

egonw commented 3 years ago

Yes, but wrong folder. Everything in docs/ is generated. Look up the query in src/sparql/ please. Sorry for the confusion.

lubianat commented 3 years ago

Oh no, I did it again, sorry. I'm gonna fix it.