version-configurable - Githubissues

egor-tensin / setup-mingw

GitHub action to set up MinGW-w64

MIT License

74 stars 25 forks source link

version-configurable #11

Closed general-kroll-4-life closed 1 year ago

general-kroll-4-life commented 1 year ago

Background:

mingw Version 12.2.0, the chocolatey default (at the time of writing), does not correctly build my CGO / golang v1.19 binary. The binary does build correctly with mingw Version 8.1.0 and possibly other previous versions.
Therefore, adding this feature to make mingw version configurable, on an opt-in basis.

Summary:

mingw version configurable through input.
If no version is supplied, then mingw version will fall back to package manager default.

Evidence:

https://github.com/stackql/setup-mingw/actions/runs/3825627764

Notes:

From this discussion, my specific issue may well be alleviated with the upcoming (February 2023) release of golang v1.20, nevertheless mingw version pinning may well remain useful.

general-kroll-4-life commented 1 year ago

@egor-tensin can you please review this? 🙏

egor-tensin commented 1 year ago

Sorry, I was in no fit state to deal with my GitHub Actions for the past year. I'll try to keep up in the future.

Released. I added a job to the CI workflow which installs v8.1.0; seems to be fine.

general-kroll-4-life commented 1 year ago

Sorry, I was in no fit state to deal with my GitHub Actions for the past year. I'll try to keep up in the future.

Released. I added a job to the CI workflow which installs v8.1.0; seems to be fine.

Thank you kindly 🙏