search

egor-tensin / setup-mingw

GitHub action to set up MinGW-w64
MIT License
77 stars 25 forks source link

Allowing later versions of mingw from chocolatey #3

Closed Honeybunch closed 1 year ago

Honeybunch commented 2 years ago

I ran into some code for a PR here: https://github.com/KhronosGroup/KTX-Software/pull/574 Where I needed a newer version of gcc from mingw to avoid some compiler bugs. The newer version of mingw on chocolatey seems to work fine so I removed the explicit versioning

jonesmz commented 2 years ago

I second this. I think i'm running into a bug caused by older mingw.

Ideally this could be exposed as an option.

chronoxor commented 2 years ago

MinGW version 8.1.0 is far to old. New builds are available here: https://github.com/niXman/mingw-builds-binaries/releases

coffeebe4code commented 2 years ago

I vote this be an optional parameter to the runner like cc, static, etc.

I could see a default value being 8.1.0.

This would prevent others who rely on an older version of gcc, pthreads, or other libraries.

coffeebe4code commented 2 years ago

I have a PR which allows for an optional version, this would allow the github action to use the same v2. Unless that is a requirement for github actions to increase every time. If we can't get this merged in within a week or two, I might just use my branch and action. I also would like to see if we can add caching or a custom image, so the install time isn't 5 plus minutes.

https://github.com/egor-tensin/setup-mingw/pull/7

egor-tensin commented 1 year ago

Sorry, I was in no fit state to deal with my GitHub Actions for the past year. I'll try to keep up in the future.

This has been implemented by somebody else and released. Thank you very much for your input.

coffeebe4code commented 1 year ago

You PR'd the wrong one imo. I moved on from this project and action, but you would have broken anyone trying to rely on the default being 8.1.0. You made it so they can't install a specific version either.