Closed egouldo closed 1 month ago
I think I have fixed this but will need to check how it looks when rendered
I think I have fixed this but will need to check how it looks when rendered
Thanks @hannahsfraser , I've made a few minor changes. PS if you view the document in "visual" mode rather than "source" mode in RStudio, and put your curser inside the $$, RStudio will show you what the rendered equation looks like without actually having to render the document:
Also, While the original text did say:
Note that for the response variables that were scaled and centered, or else mean-centred before model fitting, we do not need to standardise because these are already on the Z-scale. In doing so we make the assumption that analysts' data subsetting will have little effect on the outcomes.
This is not actually how it was implemented because I did not have capacity to go through and double check whether every analysis response variable was scaled+centred or not.
So we have two options:
I vote for the latter. The calculation wasn't pre-registered so we don't have to adhere to it. We are placing less weight on the out-of-sample meta-analyses anyways, so I am not so concerned about additional uncertainty being introduced into each estimate.
What do you think @hannahsfraser @itchyshin ?
Note, I've merged the pull request changes into 42-mv-fns-2-pkg for now, but leaving issue open.
Also, While the original text did say:
Note that for the response variables that were scaled and centered, or else mean-centred before model fitting, we do not need to standardise because these are already on the Z-scale. In doing so we make the assumption that analysts' data subsetting will have little effect on the outcomes.
This is not actually how it was implemented because I did not have capacity to go through and double check whether every analysis response variable was scaled+centred or not.
So we have two options:
- [ ] double check implementation in each analysis to see if was scaled+centred,
- [ ] remove this text, and scale and centre all out of sample estimates anyway.
I vote for the latter. The calculation wasn't pre-registered so we don't have to adhere to it. We are placing less weight on the out-of-sample meta-analyses anyways, so I am not so concerned about additional uncertainty being introduced into each estimate.
What do you think @hannahsfraser @itchyshin ?
So in checking egouldo/ManyEcoEvo/ I realised that we had already assigned z.scored responses to the identity_back()
transformation. Therefore we do correctly implement this calculation. Marking as closed.
Reopening because want to replace the text VAR.
We don't actually calculate the variance, but supply this as the variance arg to metaphor.
I think we should just update the text to accurately reflect what we did and leave it at that
Sounds like a good plan Hannah. Happy to action that.
Note current working version is here: https://github.com/egouldo/ManyAnalysts/blob/42-mv-fns-2-pkg/supp_mat/SM2_EffectSizeAnalysis.qmd
Here's where the equation / text are: https://github.com/egouldo/ManyAnalysts/blame/fea6e7bb68375f22e3a32d6cf08dde02868d9a3e/supp_mat/SM2_EffectSizeAnalysis.qmd#L694-L699
Can you please:
Note, you can make x bar with:
\bar{x}
From https://github.com/metamelb-repliCATS/ManyAnalysts/issues/127#issuecomment-1157261193
Originally posted by @egouldo in https://github.com/metamelb-repliCATS/ManyAnalysts/issues/38#issuecomment-1157262650