egov-itmo / derevo

MIT License
3 stars 1 forks source link

Refactor get_combined.py #14

Closed pashtetttt closed 1 year ago

pashtetttt commented 1 year ago

Перенес строки, длина которых превышает 79 символов, в несколько строк. Добавил комментарии (можно как-то подкорректировать).

kanootoko commented 1 year ago

79 characters per line (PEP-8 rule) looks a bit too-old when full-HD monitors 16:9 became standard and 21:9 and wider came to the market. So we use a line length limit of 120 characters. If you have arguments, we can debate. Considering the refactor, current updated version is already formatted with Black and checked with pylint, so I'm closing this issue.

Upcoming version - https://github.com/egov-itmo/landscaping/issues/15 (as I ses it, we cannot use Draft PRs unless the repository is public - and it is private for some reason)