Refactor compositioner method

egov-itmo / derevo

MIT License

3 stars 1 forks source link

Refactor compositioner method #15

Closed kanootoko closed 1 year ago

kanootoko commented 1 year ago

I have done some refactoring work for the method, but didn't really test its work.

Following changes are stilll to be made:

use all of the methods in example script
add type hints to all of the input parameters (what type is greenery_polygon?)
it would be great to add to methods docstrings some information about dataframes (used columns, types, etc.)
methods with 5-8 dataframes input arguments look monstrous, so if there are any ideas of gracefully combining them to one model, try it.

kanootoko commented 1 year ago

@pashtetttt you may look to this branch for further improvements

kanootoko commented 1 year ago

@Sandrro I've updated refactor branch adding mocked methods get_composition and get_territory to compositioner module. The second one is currently optional, but the first needs to be implemented (reusing old methods with DataFrames where possible, I think) in the near future.